Do not delete app's package.json #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
App's package.json contains information about application's entry point, so we should not delete it.
|
👍 but we really need to clear the user confusion with multiple package.json files |
|
Test PASSed. |
|
Well, searching for a package.json file in a folder to find the main executable is a part of the philosophy of the runtimes. We'd better make that clear enough everywhere possible so that the users don't get confused. By the way, examples of confusion could help clear out the next steps... |
rosen-vladimirov
added a commit
that referenced
this pull request
Dec 1, 2015
…json-delete Do not delete app's package.json
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App's package.json contains information about application's entry point, so we should not delete it.